docs(gfql): expr_const_fold module header 108 → 18 lines - #1867
Merged
Conversation
The last big prose block. Coverage check first: test_expr_const_fold.py has 49 tests GROUPED BY the very criteria the header enumerated -- TestAsciiGate, TestArgumentClosure, TestNullAndBooleanPolicy, TestTotality. The (P)/(A)/(E) enumeration was restating class names. What survives is the one thing those tests cannot say: WHY the ASCII gate exists. pandas>=3 defaults to Arrow-backed str whose utf8_lower/utf8_upper are SIMPLE per-codepoint case mappings while polars' and Python's are FULL, so folding a non-ASCII literal in Python bakes in a mapping the evaluating engine disagrees with (#1802). Plus the directive that widening the gate needs a proof, not a sample -- a test cannot express 'do not widen this on a spot check'. AST identical; 222 const-fold tests pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MF7uRZLKZaD6Q9FGWSmyXi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last large prose block in the GFQL diet.
Coverage check first (the correction from #1864):
test_expr_const_fold.pyhas 49 tests grouped by the very criteria the header enumerated —TestAsciiGate,TestArgumentClosure,TestNullAndBooleanPolicy,TestTotality. The (P)/(A)/(E) enumeration was restating class names.What survives
Only the thing those tests cannot say: why the ASCII gate exists. pandas>=3 defaults to an Arrow-backed
strwhoseutf8_lower/utf8_upperare simple per-codepoint case mappings, while polars' and Python's are full mappings. Folding a non-ASCII literal in Python bakes in the full mapping and silently disagrees with the engine evaluating the column side (#1802).Plus one directive: widening the gate requires proving engine agreement, not sampling it. A test cannot express "do not widen this on a spot check."
AST identical via
bin/ci_docs_only_check.py; 222 const-fold tests pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01MF7uRZLKZaD6Q9FGWSmyXi