feat(models): make retrieval and fusion score semantics explicit (#90) - #142
Muhammad-AbdullahGhani wants to merge 1 commit into
Conversation
|
Hey @Muhammad-AbdullahGhani, |
|
Hi @SaadBazaz, I have starred and forked the repo.. |
|
Thanks for working on this. We’re continuing with #144 for #90, so I’m closing this overlapping implementation. This version hardcodes cosine even though indexes can use other distance metrics, and adds duplicate rank and channel fields that need to stay synchronized. #144 reads the configured metric and uses the existing fields, though it still needs changes from review. If you’d like to contribute further to this issue, feel free to coordinate with @AhmedIrfan7 on #144. I’ve left specific feedback there that you could work through together. Your bounded-moment fix in #141 is merged. Thanks for following through on that. |
Related issue
Closes #90
Summary
Validation