fix(toolkit): keep source DB intact when DbMove copy fails - #140
Open
halibobo1205 wants to merge 1 commit into
Open
fix(toolkit): keep source DB intact when DbMove copy fails#140halibobo1205 wants to merge 1 commit into
halibobo1205 wants to merge 1 commit into
Conversation
Prevent the prior flow from deleting source databases after logging and ignoring per-file copy errors. Preserve every source until all configured databases copy successfully. Roll back partial destinations, handle recursive database contents, and return a non-zero status on failure. Finalize symlinks only after the copy phase completes, report completion once, and cover rollback and direct retry behavior in DbMoveTest.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
added
the
size:XL
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
Comment on lines
+131
to
+136
| try (Stream<Path> files = Files.walk(p.original)) { | ||
| ProgressBar.wrap(files.parallel(), p.name).forEach(source -> { | ||
| try { | ||
| copyEntry(p, source); | ||
| } catch (IOException e) { | ||
| hasError.set(true); |
There was a problem hiding this comment.
Suggestion: The copy phase traverses and copies a live database tree without stopping the database, acquiring a lock, or taking a snapshot. Concurrent database writes can produce a destination containing files from inconsistent points in time, after which the source is deleted and replaced by a link. The move must require an offline database or use a consistent database-level snapshot/lock. [incomplete implementation]
Severity Level: Critical 🚨
- ❌ Running-node moves can produce inconsistent RocksDB copies.
- ❌ Finalization can replace the source with incomplete state.
- ⚠️ Restarted nodes may require database recovery or rollback.
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** plugins/src/main/java/common/org/tron/plugins/DbMove.java
**Line:** 131:136
**Comment:**
*Incomplete Implementation: The copy phase traverses and copies a live database tree without stopping the database, acquiring a lock, or taking a snapshot. Concurrent database writes can produce a destination containing files from inconsistent points in time, after which the source is deleted and replaced by a link. The move must require an offline database or use a consistent database-level snapshot/lock.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Prevent the prior flow from deleting source databases after logging and ignoring per-file copy errors.
Preserve every source until all configured databases copy successfully. Roll back partial destinations, handle recursive database contents, and return a non-zero status on failure.
Finalize symlinks only after the copy phase completes, report completion once, and cover rollback and direct retry behavior in DbMoveTest.
CodeAnt-AI Description
Make database moves fail safely and preserve source data
What Changed
Impact
✅ Source databases preserved after failed moves✅ No partial destination copies after copy errors✅ Safer handling of nested paths and symbolic links💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.