Allow hoisting invariant factors in rfactor#9190
Open
alexreinking wants to merge 9 commits into
Open
Conversation
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9190 +/- ##
=======================================
Coverage ? 69.37%
=======================================
Files ? 254
Lines ? 78427
Branches ? 18789
=======================================
Hits ? 54409
Misses ? 18503
Partials ? 5515 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a mode to
rfactorthat hoists invariant factors according to a detected distributive (semiring) law into the write-back part of the accumulation step. This enables writing straightforward quantized kernels in the algorithm language and factoring them into efficient kernels.On my system (Apple M3 Max, 1 core), the schedule in test/performance/tiled_matmul_arm_neon.cpp outcompetes existing schedules:
The difference in performance is in mostly due to hoisted rfactor's ability to target SDOT instructions.
Breaking changes
No breaking changes. The mode is 100% opt-in.
Just like rfactor, it is possible to write equivalent algorithms that can be scheduled equally well. However, doing so is relatively finicky and more complicated.
Checklist