Skip to content

Mark CabalSpecV3_18 as latest on the 3.18 branch - #12273

Merged
mergify[bot] merged 1 commit into
haskell:3.18from
andreabedini:andrea/fix/cabal-spec-latest-3-18
Sep 3, 2026
Merged

mergify[bot] merged 1 commit into
haskell:3.18from
andreabedini:andrea/fix/cabal-spec-latest-3-18

Conversation

@andreabedini

Copy link
Copy Markdown
Collaborator

Summary

  • mark CabalSpecV3_18 as the latest supported specification on the 3.18 branch
  • keep cabal-version: 3.18 Simple packages on the in-process setup path

Background

Cabal-syntax 3.18 recognizes CabalSpecV3_18, but cabalSpecLatest remained
CabalSpecV3_16. cabal-install therefore classified Simple packages that
declare cabal-version: 3.18 as future-format packages and selected an external
setup script.

Addresses #12271.

Testing

  • cabal build Cabal-syntax
  • evaluated cabalSpecLatest in the Cabal-syntax REPL and obtained
    CabalSpecV3_18

Copilot AI lite review requested due to automatic review settings August 24, 2026 08:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Cabal-syntax on the 3.18 branch so that CabalSpecV3_18 is treated as the latest supported Cabal specification, aligning cabalSpecLatest with the spec versions that Cabal-syntax 3.18 already parses and preventing cabal-install from misclassifying cabal-version: 3.18 Simple packages as “future format”.

Changes:

  • Bump cabalSpecLatest from CabalSpecV3_16 to CabalSpecV3_18.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Cabal-syntax 3.18 recognizes CabalSpecV3_18, but cabalSpecLatest remained
CabalSpecV3_16. cabal-install consequently treated Simple packages that
declare cabal-version 3.18 as future-format packages and selected an
external setup script.

Move the supported-version boundary to CabalSpecV3_18 so these packages use
the in-process setup path.

Fixes haskell#12271
@andreabedini
andreabedini force-pushed the andrea/fix/cabal-spec-latest-3-18 branch from c760b47 to a290081 Compare August 24, 2026 08:20
@andreabedini andreabedini added the merge me Tell Mergify Bot to merge label Aug 26, 2026
@mergify

mergify Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-09-03 09:47 UTC · Rule: default · triggered by rule Put release branch pull requests in the rebase+merge queue
  • Checks passed · on draft merge queue: checking #12273 on 3.18 (af0302b) #12315
  • Merged2026-09-03 12:03 UTC · at bc35630dc104dc0b9945da7b9ba297ceb9bde880 · merge

This pull request spent 2 hours 16 minutes 16 seconds in the queue, including 2 hours 4 minutes 19 seconds running CI.

Required conditions to merge
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • github-review-approved [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

@mergify
mergify Bot merged commit bc35630 into haskell:3.18 Sep 3, 2026
57 checks passed
@mergify mergify Bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days and removed queued labels Sep 3, 2026
@andreabedini
andreabedini deleted the andrea/fix/cabal-spec-latest-3-18 branch September 17, 2026 07:07
@zlonast

zlonast commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

@mergify backport master

@mergify

mergify Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

backport master

✅ Backports have been created

Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

attention: needs-backport master merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants