fix(cabal-install): cabal test runs the tests of the targets that have them

[zlonast]

fix: #11858

$ cabal test pkg-with-tests pkg-without-tests
No tests to run for the package pkg-without-tests-0.1.0.0
Running 1 test suites...
Test suite pkg-with-tests-test: PASS
1 of 1 test suites (1 of 1 test cases) passed.

---

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
  • Is the change significant? If so, remember to add significance: significant in the changelog file.
• The documentation has been updated, if necessary.
• Manual QA notes have been included.
• Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

[chreekat]

I have pointed out a few typical mistakes made by agents of the current era. There are more to be found. I suggest taking a look and trying to improve its output.

[chreekat]

I don't understand why this test changed. The inline comment on new line 1422 doesn't explain it. At most, it makes it sound like this test has gotten worse by testing the same thing as the new test.

[chreekat]

This whole changelog entry is too long. Probably 10x too long in terms of lines.

[chreekat]

Previously the noticing or dying happened inside reportTargetProblems. I think that should continue to be the case, rather than splatting it into a higher level.

[chreekat]

This comment edit is sloppy. It doesn't seem to be telling me anything important about this function in particular. It says a target is skipped with a notice, but there is no notice happening here? And there's no commit message explaining why this function changed. It's hard to understand the intent.

[chreekat]

Sorry to rain on your parade with this review. I do appreciate that you tackled the issue I raised! The new test looks fine; if the impl was cleaned up I'm sure this would actually fix my problem.