Skip to content

sync - #563

Closed
Suyaj wants to merge 3 commits into
hect0x7:masterfrom
Suyaj:master
Closed

sync#563
Suyaj wants to merge 3 commits into
hect0x7:masterfrom
Suyaj:master

Conversation

@Suyaj

@Suyaj Suyaj commented Aug 13, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • New Features
    • Added an optional search keyword input to download workflows.
    • Matching albums are now included automatically when search keywords are provided.
    • Search results are combined with manually configured album selections.

@github-actions

Copy link
Copy Markdown

To prevent beginners from mistakenly submitting PRs,
if your PR only modifies the usage/workflow_download.py file,
it will be automatically closed.
If you really want to submit a PR, please reopen it yourself.
Make sure you know what you are doing!

@github-actions github-actions Bot closed this Aug 13, 2026
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 04ab18bc-172e-4e6e-b17d-60bbe7b7c690

📥 Commits

Reviewing files that changed from the base of the PR and between 9785bfe and 474ad6d.

📒 Files selected for processing (2)
  • .github/workflows/download_dispatch.yml
  • usage/workflow_download.py

📝 Walkthrough

Walkthrough

The workflow accepts optional JM_SEARCH keywords. workflow_download.py searches the first result page, collects matching album IDs, combines them with configured IDs, and passes the combined list to JmcomicUI.

Changes

Workflow Search

Layer / File(s) Summary
Dispatch input wiring
.github/workflows/download_dispatch.yml
The workflow declares optional JM_SEARCH input and passes it to the crawler job environment.
Search and album ID merge
usage/workflow_download.py
get_id_search() reads JM_SEARCH, retrieves matching album IDs, and returns an empty list when unset. main() combines these IDs with configured album IDs before assigning them to JmcomicUI.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant GitHubActions
  participant workflow_download.py
  participant Site
  participant JmcomicUI
  GitHubActions->>workflow_download.py: Pass JM_SEARCH
  workflow_download.py->>Site: Search keywords on first result page
  Site-->>workflow_download.py: Return matching album IDs
  workflow_download.py->>JmcomicUI: Assign combined album IDs
Loading

Possibly related PRs

Suggested reviewers: hect0x7

✨ Finishing Touches 💡 1
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch master
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant