feat: add lint_config input for custom yamllint rules - #208
Bisman-Singh wants to merge 3 commits into
Conversation
|
@cpanato could you review this when you have a moment? |
ac5b762 to
877b402
Compare
877b402 to
d4f77f0
Compare
|
Friendly ping on this one — it's been open a while. Recap: this adds an optional Happy to rebase onto |
|
@Bisman-Singh can you rebase to fix the conflicts? thanks |
Fixes helm#176 Signed-off-by: Bisman-Singh <bismanmadaan1@gmail.com>
Signed-off-by: Bisman-Singh <bismanmadaan1@gmail.com>
d4f77f0 to
c581b55
Compare
|
Rebased on main, thanks. The conflict was the new github_token input sitting where lint_config was added. While testing I found the old step wrote the config into the shared tool cache, which on self-hosted runners leaks into later jobs that never set lint_config, so it now passes the file through CT_LINT_CONF instead. That change is in its own commit so it's easy to review separately. |
|
can we add a ci job test to exercise this feature? thanks again |
Signed-off-by: Bisman-Singh <bismanmadaan1@gmail.com>
|
Added test_ct_action_with_lint_config. It lints the test chart with a config that only enables document-start, so it fails only when ct actually picks up the file, and it also checks that a missing file fails the action. |
Adds a
lint_configinput that lets users provide a custom yamllint config file. When set, it replaces the defaultlintconf.yamlinCT_CONFIG_DIRsoct lintpicks it up automatically.Usage:
This lets users customize yamllint rules (e.g.
min-spaces-from-content,line-length) without needing to pass--lint-confto everyct lintcall.When
lint_configis not set, behavior is unchanged.Fixes #176