Add support for Retry-After header - #1726
Open
andrey-kashcheev wants to merge 1 commit into
Open
andrey-kashcheev wants to merge 1 commit into
andrey-kashcheev wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (71.43%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1726 +/- ##
==========================================
+ Coverage 80.44% 80.48% +0.04%
==========================================
Files 358 358
Lines 14431 14443 +12
Branches 1581 1583 +2
==========================================
+ Hits 11608 11624 +16
+ Misses 2184 2177 -7
- Partials 639 642 +3
🚀 New features to boost your workflow:
|
Optional additional waiting time between retry attempts. Only version with seconds is supported Relates-To: DATASDK-107 Signed-off-by: Andrey Kashcheev <ext-andrey.kashcheev@here.com>
andrey-kashcheev
force-pushed
the
datasdk-107-retry-after-support
branch
from
September 21, 2026 12:22
a6a333e to
14f43c2
Compare
rustam-gamidov-here
approved these changes
Sep 21, 2026
| const std::chrono::seconds::rep seconds_from_header = | ||
| std::strtol(header.second.c_str(), nullptr, 10); | ||
|
|
||
| if (seconds_from_header == LONG_MAX || seconds_from_header == LONG_MIN) { |
Collaborator
There was a problem hiding this comment.
maybe std::numeric_limits ? may depends on the http header description of course
mykolamalik
reviewed
Sep 21, 2026
Comment on lines
+316
to
+317
| const auto actual_wait_time = std::min( | ||
| wait_time, settings->max_wait_time - settings->accumulated_wait_time); |
Collaborator
There was a problem hiding this comment.
If the RetryAfterWaitTime is a big enough number, it may be ignored. Is it really what we want to achieve?
Same question to the line 875
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional additional waiting time between retry
attempts. Only version with seconds is supported
Relates-To: DATASDK-107