fix: make Proof Lab Pages build independently testable - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#63 correctly removed SkillFactory-era Pages coupling, but the first main-branch Pages run exposed a missing import path: the static builder still imported
skill_factoryafter editable installation was removed.This hotfix removes the package dependency entirely:
site/artifact and only generatesdata/build.json;site/data/capabilities.jsonremains the source of the public capability table;frontend-smokenow runs the exact static build and servesdist/, so deployment-build failures are caught before merge.The change is specifically aimed at closing the gap that let #63 pass PR CI while the first main Pages build failed.