fix: back off invalid metadata jobs and stop re-mints from wiping token metadata - #360
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds invalid-job backoff and preserves token metadata during re-mints.
Changes:
- Adds configurable invalid-job retry delay.
- Preserves fetched metadata when re-enqueuing minted tokens.
- Adds queue and SFT re-mint regression tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/env.ts |
Defines the invalid-job backoff setting. |
src/pg/stacks-core-pg-store.ts |
Preserves metadata and schedules invalid-job retries. |
src/token-processor/queue/job/job.ts |
Applies backoff after user errors. |
tests/token-queue/job.test.ts |
Tests invalid-job backoff. |
tests/stacks-core/sft-events.test.ts |
Tests metadata preservation after re-minting. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rafa-stacks
marked this pull request as ready for review
August 28, 2026 15:38
bgridley-stacks
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A token's job row is re-enqueued as
pendingon every re-mint (the JSON behind a token URI can be fixed without the contract ever changing). ButupdateJobStatusclearedretry_afterfor any non-pendingstatus, so a job that had just been markedinvalidwas pickable again the instant the next mint landed.Now a
UserErrorsetsretry_after = NOW() + JOB_QUEUE_INVALID_RETRY_AFTER_MS(new env var, default 1h).