Restore agent prosecutor authority access (CIMD-3294) - #60
Merged
allanmckenzie merged 1 commit intoJul 3, 2026
Merged
Conversation
The Java 25 migration recreated ProsecutingAuthorityAccess from main, which never had the CIMD-3294 "agent prosecutors access" feature that was released on the 17.104.x line. Restore it (additively, keeping of(String) so existing callers/tests are unaffected): - ProsecutingAuthorityAccess: agentProsecutorAuthorityAccess list, of(String,List), getAgentProsecutorAuthorityAccess(), and hasAccess() honouring the agent list. - ProsecutingAuthorityProvider: parse the agentProsecutorAuthorityAccess array from the user-details response. Consumers (e.g. mi-reportdata SJP resulted-cases/cases-count queries) depend on getAgentProsecutorAuthorityAccess().
allanmckenzie
requested review from
oktayekincioglu,
santhosh-hmcts and
zozd-hmcts
July 3, 2026 15:21
oktayekincioglu
approved these changes
Jul 3, 2026
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Java 25 migration of
access-control-sjp-providersrecreatedProsecutingAuthorityAccessfrommain, which never contained the CIMD-3294 "agent prosecutors access" feature — that was released only on the17.104.xline (PR #54). SogetAgentProsecutorAuthorityAccess()was silently dropped on the 25.104.x stack.Consumers depend on it — e.g.
cpp-context-mi-reportdata's SJPResultedCasesService/CasesCountQueryApifail to compile against 25.104.x withcannot find symbol getAgentProsecutorAuthorityAccess().Fix (additive)
ProsecutingAuthorityAccess: restore theagentProsecutorAuthorityAccesslist,of(String, List<String>),getAgentProsecutorAuthorityAccess(), andhasAccess()honouring the agent list. The existingof(String)and behaviour are kept intact, so current callers/tests are unaffected.ProsecutingAuthorityProvider: parse theagentProsecutorAuthorityAccessarray from the user-details response and pass it toof(...).ProsecutingAuthorityAccessTest; existing tests unchanged and green (module: 17 tests, 0 failures).Audited the other 15 commits on
release/17.104.xnot inmain: all are release-pipeline version bumps except #45 (a dependency already present in 25.104.x) and #39 (changelog/version only) — CIMD-3294 was the only missing code.🤖 Generated with Claude Code