fix(dev): repair make up/test#952
Open
alexluong wants to merge 2 commits into
Open
Conversation
…in localstack `make up/test` broke after the dev-stack unify (#930) removed the external `outpost` network and `make network`. The test compose still pinned its default network to `external: outpost`, so the project failed to start. The test suite reaches every service via mapped localhost ports (.env.test), never by container DNS, so the shared network was never load-bearing. Drop the override and let the `outpost-test` project auto-create `outpost-test_default` — which also matches what redis-cluster-compose expects. Also pin localstack to `:3`; `:latest` now resolves to a 2026.x build that gates startup on a Pro license token. The 3.x community line runs s3/sns/sts/sqs/kinesis free. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
make up/test
The e2e basic config forced a timestamped signature template
(t={{.Timestamp.Unix}},v0=...) left over from before #808. That refactor
removed timestamps from the default templates and updated the mock server
to verify the bare default (v0= over {{.Body}}), but never updated this
override — so signing and verification diverged.
The mismatch was masked for months because compose reuses the cached
`outpost-mock` image; it only surfaced on a fresh mock rebuild. Drop the
override so e2e exercises the real product default and matches the mock.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
alexbouchardd
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local dev fix:
make up/testwas broken. Two changes tobuild/test/compose.yml:outpostexternal network. The dev-stack unify (chore(dev): unify local dev stack into one compose project; add make health + make smoke #930) removed it, but the test compose still pinned to it, so the project wouldn't start. Tests reach services via localhost ports (.env.test), so the network was never load-bearing — the project now auto-createsoutpost-test_default.:3.:latestnow gates startup on a Pro license token; the 3.x community line runs s3/sns/sts/sqs/kinesis free.Verified:
make up/testbrings up all containers clean, localstack services available, no license error.