Skip to content

fix: remove deprecated VQModel/VQEncoderOutput shim past target version 0.31 - #14392

Open
lorenzozanee wants to merge 1 commit into
huggingface:mainfrom
lorenzozanee:fix/vq-model-shim-removal
Open

fix: remove deprecated VQModel/VQEncoderOutput shim past target version 0.31#14392
lorenzozanee wants to merge 1 commit into
huggingface:mainfrom
lorenzozanee:fix/vq-model-shim-removal

Conversation

@lorenzozanee

@lorenzozanee lorenzozanee commented Aug 5, 2026

Copy link
Copy Markdown

What does this PR do?

Fixes #14365
Adds a regression test (5 assertions) verifying the shim is gone, the old import
path raises ImportError, and VQModel remains accessible from the public API.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

@lorenzozanee

Copy link
Copy Markdown
Author

AI Self-Review: READY

Validated against: .ai/review-rules.md, .ai/AGENTS.md, .ai/testing.md

Checks Run

Check Result
Regression tests (5/5) PASS
ruff check PASS
ruff format PASS
utils/check_copies.py PASS
utils/check_dummies.py PASS
utils/check_support_list.py PASS
utils/check_forward_call_docstrings.py PASS
make deps_table_check_updated PASS
git diff --check PASS
tests/models/autoencoders/test_models_vq.py PASS (17 passed, 0 failures)

Upstream-only CI

Jobs that require the upstream PR environment and cannot be verified locally:

  • pr_tests.yml (fast tests)
  • pr_dependency_test.yml
  • pr_torch_dependency_test.yml
  • pr_labeler.yml (label automation)

No Blocking Findings

  • Coding style: conforms to project conventions
  • Copied code rules: not applicable (no # Copied from blocks touched)
  • Dead code analysis: the deleted file was unreachable via __init__.py exports; all remaining import paths use the canonical autoencoders.vq_model location
  • No debug logs, large files, or sensitive data in the diff

…on 0.31

Fixes huggingface#14365. The deprecation target (0.31) has passed; the shim now raises
ValueError on every instantiation. Delete the shim and route the single
remaining importer (PaellaVQModel) to the canonical autoencoders.vq_model path.
@lorenzozanee
lorenzozanee force-pushed the fix/vq-model-shim-removal branch from 8989ea2 to 55dd59d Compare August 5, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated VQModel/VQEncoderOutput shim (past target version 0.31)

1 participant