Conversation
The `get_i2v_mask` method had a hardcoded `device="cuda"` default, which crashes on non-CUDA accelerators (Ascend NPU, etc.) with "Torch not compiled with CUDA enabled" when called without an explicit device argument. Change the default to None and resolve via `self._execution_device`, matching the pattern used across other pipeline methods. Verified on Ascend 910B NPU: torch.zeros(device="cuda") crashes, fix with device-agnostic resolution creates tensors on the correct device.
The VAE decode block in the MiniMax H3 pipeline only enables fp16 autocast on CUDA (`enabled=device.type == "cuda"`), which disables autocast on other accelerators such as Ascend NPU, causing suboptimal performance and potential dtype mismatches. Change to `enabled=device.type != "cpu"` so autocast is enabled on any accelerator device while remaining disabled on CPU. Verified on Ascend 910B NPU: torch.autocast(device_type="npu", dtype=torch.float16, enabled=True) correctly computes in fp16.
|
Closing in favour of #14883. Two things changed since this was opened:
Thanks! |
Fixes #14882
Description: The VAE decode block in the MiniMax H3 modular pipeline only enables fp16 autocast on CUDA devices (
enabled=device.type == "cuda"), which disables autocast on other accelerators such as Ascend NPU, Intel XPU, or Apple MPS.Without autocast on NPU, the VAE decode runs in fp32 (or the tensor's dtype without fp16 acceleration), causing suboptimal performance and potential dtype mismatches when the pipeline expects half-precision computation.
Change:
enabled=device.type == "cuda"->enabled=device.type != "cpu"Verification on Ascend 910B NPU (torch 2.14.0a0 + torch_npu):
torch.autocast(device_type="npu", dtype=torch.float16, enabled=True)produces fp16 output (out.dtype=torch.float16)torch.autocast(device_type="npu", dtype=torch.float16, enabled=False)produces fp32 outputNotes: (1) end-to-end NPU decode speed-up of this change is not measured - only the dtype path above was checked; (2) CUDA behaviour is unchanged; (3) the branch also carries the
get_i2v_maskdevice-default commit shared with #14765; (4) this is unrelated to the separate CPU/VRAM trade-off discussed in #14746.(Replaces #14766, which the issue-link auto-close bot closed on 2026-09-25 and which GitHub refused to reopen - same commit, unchanged content.)