Skip to content

Unify app button system - #78

Merged
Cyber-preacher merged 1 commit into
masterfrom
refactor/unified-app-buttons
Sep 4, 2026
Merged

Unify app button system#78
Cyber-preacher merged 1 commit into
masterfrom
refactor/unified-app-buttons

Conversation

@Cyber-preacher

Copy link
Copy Markdown
Contributor

Why

Buttons had drifted across the app through raw native controls, local typography and sizing overrides, and a global font reset that rendered native buttons differently from linked buttons. The mismatch was especially visible in the top-right actions on Draft cards.

Changes

  • Expand the shared Button primitive with canonical destructive, bare, icon, toolbar, and content variants.
  • Route every native button and simulated button role through the shared primitive.
  • Remove local font, opacity, height, radius, and padding overrides where the primitive owns presentation.
  • Align Draft visibility actions with the other Draft card controls.
  • Fix mobile action wrapping in faction creation and Vortexopedia rows.
  • Add a source-wide regression guard against raw buttons and an end-to-end computed-style check for Draft actions.

Validation

  • yarn test: 243 tests passed across 55 files
  • yarn typecheck
  • yarn build
  • yarn prettier:check
  • yarn test:e2e: 121 tests passed
  • Desktop and 390px browser audits across app routes
  • git diff --check

@Cyber-preacher
Cyber-preacher merged commit 37f1efc into master Sep 4, 2026
6 checks passed
@Cyber-preacher
Cyber-preacher deleted the refactor/unified-app-buttons branch September 4, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant