Add Collected::take_trailers - #114
Merged
Merged
Conversation
swlynch99
force-pushed
the
collected-take-trailers
branch
from
March 14, 2024 23:16
2533f8f to
cd52d9d
Compare
Member
|
i have wished for this method myself, i'd support this addition. +1 |
cratelyn
approved these changes
Sep 2, 2026
Member
|
@swlynch99 pardon the delay. i would like to merge this. to help CI run, would you mind rebasing this on top of the latest |
swlynch99
force-pushed
the
collected-take-trailers
branch
from
September 4, 2026 00:02
cd52d9d to
0b61670
Compare
Contributor
Author
|
I had actually assumed this crate was basically unmaintained at this point, nice to see it's being actively maintained now :) Rebased. Happy to add a test if you want as well, but I don't think this change really needs one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you want to inspect the body of a
Collectedthen there is currently no way to also keep the trailers around without cloning them. This PR adds a method that lets you directly take the trailers out of theCollected.