feat(esm): retire --deno-esm; Bun-ESM is the only JS-host ESM target - #759
Merged
Merged
Conversation
--deno-esm / -o *.deno.js is a hard error (E0826) pointing at --bun-esm.
codegen_deno now emits the Bun host. The historical codegen-deno corpus
compiles to .bun.js. Aspirational StartupError fixtures use real syntax
(use Console/Dom, tuple-list attrs, #{…} records).
Refs #56
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (51)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This was referenced Sep 21, 2026
Closed
hyperpolymath
added a commit
that referenced
this pull request
Sep 21, 2026
…o parse (#761) ## Why #759 merged with red CI: - `npm install -g --ignore-scripts tree-sitter-cli@0.25.0` leaves the `tree-sitter` binary missing (ENOENT) — build, coverage, migration-assistant. - Workflow linter requires SPDX on line 1; actions-lock prepends a managed-by comment. - `lib/codegen_deno.ml` still had a #757 smash: unterminated `(* #459` comment (`wrapping Iram)`) and a duplicate `receiver_struct` (`withtion = function`). Lint: Comment not terminated. ## This PR - `scripts/install-tree-sitter-cli.sh` installs the v0.25.0 GitHub release binary. - Workflow linter accepts SPDX in the first 5 lines. - Restore ExprBreak/Continue/Lambda arms; drop the duplicate receiver_struct. - `affinescript-vite/` compile-pass scaffold (`--bun-esm`). Does not implement #486.
|
❌ Couldn't create the docstrings branch. Warning I couldn't create the pull request branch. This branch's GitHub Actions workflow files ( How to fix: update this branch with If this branch is already up to date with |
|
❌ Failed to create Coding Agent finishing-touch task. Please try again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bun-ESM is the only JS-host ESM target.
--deno-esm/-o *.deno.jsis a hard error (E0826) pointing at--bun-esm/.bun.js. The flag is kept so existing scripts fail loudly instead of becoming an unknown option.codegen_denonow emits the Bun host (codegen_deno≡codegen_bun). The historicaltests/codegen-deno/corpus compiles with--bun-esmto.bun.js.Aspirational idaptik StartupError fixtures compile with real syntax (
use Console::{log},use Dom::{…}, tuple-list attrs,#{ bg: … }records) — not ReScriptimport Dom/{IO}/{style: bg}without#.Host FFI on this path does not require
/ IOrows (Canvas-style erasure at emit).affinescript-viteremains a scaffold, not in this tree. Remaining Pixi.res (~313 decls) is a follow-up, not this PR.Does not implement #486 (native-preview2 / default component; needs ocaml + wasm-tools and must keep
typedwasm.ownershipbyte-equal).Closes #56
Notes
scripts/install-bun.sh).Follow-up on this PR
scripts/install-tree-sitter-cli.sh); workflow-linter accepts SPDX in the first 5 lines (actions-lock prepend).affinescript-vite/scaffold landed (compile.affinevia--bun-esm).