Apply rustfmt across Rust sources - #73
Merged
Merged
Conversation
This repo's standards reusable pins are re-pointed at the standards default-branch HEAD, resolved live at sweep time. The prior refs are recorded in the verification line below. Three kinds of drift are repaired together and the body does not claim which one this repo had: an UNREACHABLE sha kills the run at workflow STARTUP, so GitHub reports no check at all rather than a failing one and the gate disappears instead of going red; a FLOATING ref (@main) is unpinned supply chain; a merely STALE but reachable sha silently reintroduces every bug fixed since it. files=6 pins=6 perms=0 permlines=0 from=092dedada188f56c5915f74a5fd40aac093742c3,5b1d00229e5e8c0c0fbfedc7e80f37ea50f49236 target=8f2ee508 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0178nN4Nm3neFRy5K9StZKnB
Contributor
Author
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Essentials Run ID: 📒 Files selected for processing (3)
📝 SummarySummary by CodeRabbit
WalkthroughThe pull request applies Rust formatting changes to CLI URLs, assertions, imports, and polarity conditions. Runtime behaviour, public declarations, and test coverage remain unchanged. ChangesMaintenance updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: A rabbit checks each tidy line Comment |
hyperpolymath
previously approved these changes
Sep 9, 2026
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
|
hyperpolymath
added a commit
that referenced
this pull request
Sep 15, 2026
…uild (#78) ## main has not compiled for five days `crates/squabble-cli/src/fight.rs` imports `Evidence` twice: ```rust use squabble_core::polarity::Evidence; // line 16 use squabble_core::outcome::Outcome; use squabble_core::polarity::{Applicability, Evidence, RepoDeclaration}; // line 18 -- removed ``` ``` error[E0252]: the name `Evidence` is defined multiple times --> crates/squabble-cli/src/fight.rs:18:46 ``` Line 18 was re-added by 327fb24 ("Apply rustfmt across Rust sources", #73, merged 2026-09-09 17:00 +0100). Every commit on `main` since then fails to build. ## Why the whole line goes, not just the duplicate name rustc reports **all three** names on that line as unused, and `Applicability` and `RepoDeclaration` appear nowhere else in the file. Removing only the duplicated `Evidence` would leave an `unused_imports` warning, which fails `clippy -D warnings`. ## Why CI did not stop this Worth recording, because the obvious reading is wrong. `Rust CI` **did** report `conclusion: failure` on the breaking commit itself — run at 2026-09-09T16:00:56Z on `main`. The gate was working and the failure was visible; it simply was not acted on. From 2026-09-10T22:06 onward, every `Rust CI` run on this repo is a startup failure with `jobs.total_count == 0` — the run exists, no job is created, **no check run is emitted**, and so the gate stops reporting entirely. An unrepaired repo therefore looks *greener* than a working one. That is a repo-level GitHub Actions allow-list problem (`allowed_actions: "selected"` with an empty `patterns_allowed`, which refuses the third-party actions reached transitively through `standards/rust-ci-reusable.yml`), it is **not** a problem with any file in this repository, and it is **not** addressed by this PR. It needs a settings change, which is the owner's call. ## Verification All three run on this branch, unfiltered: | Command | Result | |---|---| | `cargo check --workspace --all-features` | clean | | `cargo test --workspace --all-features` | **128 passed, 0 failed** | | `cargo clippy --workspace --all-features --all-targets -- -D warnings` | clean | Confirmed red before the change (E0252) and green after — one line deleted, nothing else touched. > ⚠ Because the `Rust CI` gate is currently startup-dead, **this PR will not get a green > Rust check from CI**. The evidence above is local. Merging it restores the build; it > does not restore the gate. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0178nN4Nm3neFRy5K9StZKnB --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reformat four Rust source files to satisfy CI formatting checks, including import ordering and standard wrapping of assertions, URLs, iterator chains, and comments. These are formatting-only changes with no intended behavioral impact.
Validation:
git diff --checkpassed; no test suite was run.View coding task