Fix CI validation, harden gate triage, and refresh automation - #84
Merged
Merged
Conversation
The dogfood gate enforced a format that no longer exists. Two defects, and
fixing only the first would have been a fake cure.
1. .githooks/validate-a2ml.sh was frozen at a pre-DEED revision (13,737 b) with
zero .deed references. Replaced with the canonical dual-accept body from
deed-ecosystem/validate-action (17,544 b), which dispatches on the DEED
s-expression head and keeps .a2ml passing as legacy. This repo's own
SPDX-License-Identifier line is preserved.
2. The detect step that GATES that validator counted only *.a2ml:
COUNT=$(find . -name '*.a2ml' ...)
- name: Validate A2ML manifests
if: steps.detect.outputs.count > 0
So on a repo that had migrated to .deed, COUNT would be 0, the validate step
would be SKIPPED, and the job would report green having validated nothing.
The selector now admits both extensions -- the same shape the K9 job in this
file already uses.
Edit 2 is behaviour-neutral today: this repo carries no .deed file, so COUNT is
unchanged. It is purely forward-correct.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0168Bgpez8mFBcAqYAj8VgEx
CodeRabbit raised three findings on the first commit. All three are correct. 1. The step summary reported the combined .a2ml+.deed count as ".a2ml file(s)", and the scorecard row was renamed to "DEED manifest" while its status still came from a find matching .a2ml too - so a repo holding only legacy manifests scored a green DEED row. That is a label asserting one thing while its check asks another, which is the exact defect class this branch exists to cure. Fixed by aligning the LABELS to the check rather than narrowing the check: narrowing to .deed only would red-score essentially every repo in the estate today (19,477 tracked .a2ml against 15 .deed), and this branch is behaviour-neutral by design. 2. Both find sites now pass -type f. A directory named *.deed is not a manifest. 3. The validator's structural-identity exemption no longer waives the schema version for .deed. DEED is the live, grammar-bearing format; legacy .a2ml keeps the exemption. Proved by control: two files in one machine-readable directory differing only by extension now get different verdicts. Severity is unchanged (warning, and the gate invokes strict:false), so no repo can turn red on this. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0168Bgpez8mFBcAqYAj8VgEx
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
Contributor
Author
|
Important Review skippedThis PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Essentials Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CI failures by removing a duplicate Rust import, formatting polarity code, making dogfood validation support DEED and legacy A2ML manifests, and preventing gate-triage comments from creating phantom scanner signatures. Also updates pinned actions, caps Dependabot PRs, removes the duplicate SonarQube workflow, and adds Gemini instruction discovery. This branch materially exceeds the stated PR #80 CI-fix scope because it includes several merged maintenance changes. Validation recorded in the commits: workspace check and Clippy passed, and all 128 workspace tests passed.
View coding task