Skip to content

fix(tests): terminate find -exec and pass {} — the placeholder step was a no-op #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 3 commits into from
Sep 14, 2026
Merged

fix(tests): terminate find -exec and pass {} — the placeholder step was a no-op #56

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e1855a
fix(tests): terminate find -exec and pass {} — the placeholder step w…
hyperpolymath Aug 26, 2026
286c029
fix(tests): export template values to the find child shell
hyperpolymath Aug 28, 2026
c85dc41
Merge branch 'main' into fix/find-exec-terminator
hyperpolymath Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/e2e/template_instantiation_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ replace_placeholder() {
}

# Replace in all text files
export TEST_REPO_NAME TEST_OWNER TEST_FORGE TEST_PROJECT_NAME \
TEST_DESCRIPTION TEST_PRIMARY_LANGUAGE TEST_AUTHOR TEST_AUTHOR_EMAIL
find "$TEST_REPO_PATH" -type f \
\( -name "*.md" -o -name "*.adoc" -o -name "*.a2ml" -o -name "*.zig" -o -name "*.idr" \
-o -name "Justfile" -o -name "Containerfile" -o -name "*.yml" -o -name "*.yaml" \
Expand All @@ -137,7 +139,7 @@ find "$TEST_REPO_PATH" -type f \
sed -i "s|$placeholder|$value|g" "$file"
fi
done
' _ "$file"
' _ {} \;
Comment thread
coderabbitai[bot] marked this conversation as resolved.

@codacy-production codacy-production Bot Aug 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

The shell script inside 'sh -c' is single-quoted, which prevents the parent shell from expanding variables. While adding '{} ;' fixes the find syntax error, variables like $placeholder and $value will be empty inside the subshell. Furthermore, since the script fragment on line 139 concludes with a 'done' statement, using '+' instead of ';' is more efficient as it allows 'find' to batch multiple files into fewer shell invocations.

Consider updating the command to pass the variables as arguments:

find ... -exec sh -c 'p="$1"; v="$2"; shift 2; for file in "$@"; do ... done' _ "$placeholder" "$value" {} +


log_pass "All placeholder tokens replaced"

Expand Down
Loading