Clarify invisible-character scanner cleanup comment - #765
Conversation
Replace the character-mode PCRE escapes (\xc2\xa0 asks for the two characters U+00C2 U+00A0, never present in any file) with the canonical byte-safe two-tier scanner from rsr-template-repo (rsr#49): scripts/check-invisible-characters.sh matches UTF-8 byte sequences under LC_ALL=C, so typographic invisibles (NBSP, soft hyphen, zero-width/bidi, BOM) warn while C0/NUL corruption blocks, and scanner failure refuses a partial pass instead of going green. tests/invisible-characters-test.sh proves the detector against fixtures that MUST trip it — including a leading BOM — and the workflow runs that proof before every scan. Also fixes the seven NBSP-bearing docs the old gate never saw. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedThis PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Essentials Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
hyperpolymath
left a comment
hyperpolymath
left a comment
There was a problem hiding this comment.
Approving CodeRabbit PR: Clarify invisible-character scanner cleanup comment.
|
🟡 NEEDS APPROVAL FROM DIFFERENT USER ✅ CodeRabbit PR approved by hyperpolymath (2 approvals total)
📋 Action: A user OTHER THAN hyperpolymath needs to approve. Once approved by different user, should merge automatically. |
2 participants
Clarifies that the scanner cleanup function removes its temporary NUL-delimited enumeration file on exit. This diverges from the task title: no PR function docstrings were added. Validation was not run because the change is comment-only.
View coding task