Skip to content

Fix/token permissions id wh002 20260911 - #778

Merged
hyperpolymath merged 5 commits into
mainfrom
fix/token-permissions-id-wh002-20260911
Sep 12, 2026
Merged

hyperpolymath merged 5 commits into
mainfrom
fix/token-permissions-id-wh002-20260911

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Closes #

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (would change existing behaviour)
  • 🕳️ Soundness fix (fixes a checker/proof false-negative)
  • 📖 Documentation
  • 🧹 Refactor / tech debt (behaviour-preserving)
  • ⚡ Performance
  • 🔧 Build / CI / tooling

How has this been verified?

Checklist

  • My commits are signed (git commit -S).
  • I ran the project's own checks/tests locally and they pass.
  • New files carry the correct SPDX-License-Identifier (code/config MPL-2.0,
    prose CC-BY-SA-4.0); I did not relicense existing files.
  • Docs are updated, and no public claim now overstates what the code does.
  • I have not introduced a soundness hole (or I have flagged where I might have).

Notes for reviewers

hyperpolymath and others added 3 commits September 11, 2026 11:27
- Update CodeQL workflow to SHA-pinned actions with persist-credentials: false
- Update reusable workflow pins to current standards main SHAs

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
…write)

This change extends the existing WH002 excessive permissions rule to detect
workflows with top-level 'contents: write' or 'write-all: true' permissions,
which are flagged by GitHub Scorecard's TokenPermissionsID check.

The rule now catches:
- permissions: write-all
- permissions: with contents: write
- permissions: with write-all: true

This addresses the TokenPermissionsID alerts that plague many repos in the
hyperpolymath and metadatastician estates. The fix pattern is to use
'contents: read' at the top level and add job-level 'contents: write'
only to jobs that need it.

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
Apply principle of least privilege for GITHUB_TOKEN:
- Change top-level permissions to read-only
- Jobs inherit read permissions, can escalate as needed

This resolves Scorecard TokenPermissionsID alerts.

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Resolves CodeQL action SHA conflicts - keeps newer SHAs from main.

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
@hyperpolymath
hyperpolymath merged commit 98513e5 into main Sep 12, 2026
14 checks passed
@hyperpolymath
hyperpolymath deleted the fix/token-permissions-id-wh002-20260911 branch September 12, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants