Fix external link icon going to new line alone#3118
Merged
Conversation
|
Preview of modified files: no change to preview. |
|
adriendupuis
commented
Apr 3, 2026
Summary
|
adriendupuis
marked this pull request as ready for review
July 22, 2026 08:01
adriendupuis
added a commit
that referenced
this pull request
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the icon indicating an external link can go to new line by itself.
For example, https://doc.ibexa.co/en/5.0/release_notes/ibexa_dxp_v5.0/#special-characters-in-online-editor within a 1590px width viewport.
With this PR, this icon can't be alone on a new line.
For example, https://ez-systems-developer-documentation--3118.com.readthedocs.build/en/3118/release_notes/ibexa_dxp_v5.0/#special-characters-in-online-editor within a 1590px width viewport.
Because of
:after, the icon is not really in the link, it's like another content element following it.The fix idea is to set the icon as a background image of the link with some padding on the right to have room for it. So, when wrapping the tag, "padding+background=icon" is attached to link content's last word.
Checklist