Described DeduplicateStamp#3317
Open
mnocon wants to merge 2 commits into
Open
Conversation
Preview of modified filesPreview of modified Markdown: |
Summary
|
mnocon
marked this pull request as ready for review
July 23, 2026 14:03
code_samples/ change report
|
bnowak
reviewed
Jul 24, 2026
Contributor
There was a problem hiding this comment.
This is not entirely true. Our ibexa.messenger.bus supports only default middleware/stamps with basic functionality of messenger + our implemented middlewares/stamps. What it supports is explicitly configured by us, and below is the current list:
- all Symfony default middlewares described in https://symfony.com/doc/7.4/messenger.html#middleware. Additionally to this list, we support the technical middleware https://github.com/symfony/messenger/blob/7.4/Middleware/RejectRedeliveredMessageMiddleware.php, but I don't think we need to mention that in doc. Also, since Symfony 8.1 there's a new default
decode_failed_message, but we don't support it (https://symfony.com/doc/current/messenger.html#middleware). - 3 our stamps are already mentioned
shortly, I wouldn't mention that we support (all) stamps available in Symfony because it's not true. All supported Symfony stamps are the most basic ones, which deliver only basic messenger functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target: 5.0, 4.6, 6.0
Some minor changes for 4.6 will be needed (adjusting the version)
In 6.0 Deduplicate stamp is removed, so the whole section can be removed.
The deprecation is mentioned in #3279 already