Handle IG instrument navigation API update - #379
Merged
Conversation
Allows easy running of unit tests with or without integration tests
Also included in unit tests.
Avoids "too many API requests" errors
…is False The resolution value passed was ignored previously when return_dateframe is true, which it is by default when Pandas is present.
SteveHussey
force-pushed
the
ig_api_update
branch
from
September 1, 2026 23:57
f22b222 to
c03f4e3
Compare
Member
|
@SteveHussey thanks for contributing. can you check the integration tests for the category stuff please? I tried with python 3.10 and 3.13 |
fetch_top_level_navigation_nodes and fetch_sub_nodes_by_node have been replaced by fetch_categories and fetch_category_instruments. The main differences here is that IG appear to have removed the Node ID concept from their public API. Instrument discovery for all instruments is now: call fetch_category_instruments(category) with all categories from fetch_categories().
This library is only used by sample code.
SteveHussey
force-pushed
the
ig_api_update
branch
from
September 2, 2026 13:17
c03f4e3 to
782d371
Compare
Contributor
Author
|
The integration test should be good now, I had some difficulties getting them to run locally. Gotta love Pandas sometimes! Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primarily this PR addresses the not so recent change that IG made to their REST API, replacing
fetch_top_level_navigation_nodesandfetch_sub_nodes_by_nodewithfetch_categoriesandfetch_category_instruments. This is not a like for like change as they have removed the concept of Node ID from their public API.There are also a number of more minor improvements and fixes.
No LLMs were used for this change.