Skip to content

fix: make legacy dataset provenance explicit #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shawcharles wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: make legacy dataset provenance explicit #723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75376d2
fix: make legacy dataset provenance explicit
charlesshawmsix Jul 23, 2026
b611147
fix: preserve verified dataset downloads on cache write failure
charlesshawmsix Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
event-study surface) and M-093 (4.0 sentinel retirement, phase 5) are added.
**Estimator equations, weighting, variance, and numerical output are unchanged.**

### Fixed
- **Legacy dataset loaders no longer silently present synthetic observations as
canonical data.** `load_card_krueger()`, `load_castle_doctrine()`, and
`load_mpdta()` now use commit-pinned, SHA-256-verified sources with schema and
panel-invariant validation; successful frames expose a dataset-specific
`df.attrs["source"]`. Download, checksum, parsing, or validation failures emit
exactly one `UserWarning` containing `SYNTHETIC` and mark the fallback as
`source="synthetic_fallback"`. `load_divorce_laws()` now follows that explicit
fallback path because no verified source currently reproduces its composite
public schema without additional analytical choices. Verified fresh downloads
are returned even when best-effort cache persistence fails.

### Changed
- **DiagnosticReport's parallel-trends check upgrades from the Bonferroni fallback to
the joint Wald test for StackedDiD and TwoStageDiD event-study fits.** The check's
Expand Down
Loading