critical radius and supersat: return infinities if kappa=0 instead of… - #498
Open
pdziekan wants to merge 1 commit into
Open
critical radius and supersat: return infinities if kappa=0 instead of…#498pdziekan wants to merge 1 commit into
pdziekan wants to merge 1 commit into
Conversation
… throwing an assert
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the kappa-Köhler diagnostics helpers to avoid asserting on kappa == 0 (nonhygroscopic particles), aiming to return “infinite” critical radius/supersaturation values instead.
Changes:
- Relaxed
assert(kappa > 0)toassert(kappa >= 0)inrw3_cr()andS_cr(). - Added early returns for
kappa == 0inrw3_cr()andS_cr().
Suppressed comments (1)
include/libcloudph++/common/kappa_koehler.hpp:181
- Same as rw3_cr(): for kappa==0 this returns a finite value (44) even though the intent/comment says “infinity (or close)”. Returning a true infinity makes it unambiguous to API consumers that activation is impossible for nonhygroscopic particles.
if(kappa == 0) return 44; // return infinity (or close) - nonhygroscopic particles do not activate, S_cr is used for diagnostics only
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| { | ||
| assert(kappa > 0); | ||
| assert(kappa >= 0); | ||
| if(kappa == 0) return real_t(44) * si::cubic_metres; // return infinity (or close) - nonhygroscopic particles do not activate, and rw3_cr is used for diagnostics only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… throwing an assert