fix(ui-table): fix caption for table to be responsive to sorting#2574
Open
HerrTopi wants to merge 1 commit into
Open
fix(ui-table): fix caption for table to be responsive to sorting#2574HerrTopi wants to merge 1 commit into
HerrTopi wants to merge 1 commit into
Conversation
|
Visual regression report✅ No changes.
Baselines come from the |
ToMESSKa
requested changes
Jun 3, 2026
matyasf
requested changes
Jun 18, 2026
ToMESSKa
requested changes
Jul 8, 2026
ToMESSKa
left a comment
Contributor
There was a problem hiding this comment.
- In v11.6 examples, there is no announcement which column the table is sorted by (see below)
- also there is no announcement when I change the sorting in the v11.6 examples
Can you please take a look at these?
@HerrTopi The title of the table (Top rated movies) is not announced in the v11.6 example.
Can you please fix that too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


changes the Table caption prop from an auto-appended hardcoded English "Sorted by..." string to a consumer-supplied function (sortByHeader, sortDirection) => string, so the caption reflects sort state in a fully localizable way. In v1 this is non-breaking (caption accepts a ReactNode or a function), while v2 now requires caption to be a function (breaking change), with tests, docs, and the regression page updated accordingly.
TESTS_PLAN
INSTUI-5047