Reapply "[llvm][clang] Enable IO sandbox for assert builds" (#184545) - #22779
Draft
ianayl wants to merge 5 commits into
Draft
Reapply "[llvm][clang] Enable IO sandbox for assert builds" (#184545)#22779ianayl wants to merge 5 commits into
ianayl wants to merge 5 commits into
Conversation
This reverts #173074 and essentially reapplies #171935. The main reason for the revert was an omission where we were not sandboxing direct clang -cc1 invocations in our test suite, leading to sandbox violations reported by Clang users. This was rectified in #174653 after a number of patches fixing found sandbox violations. RFC: https://discourse.llvm.org/t/rfc-file-system-sandboxing-in-clang-llvm/88791
ianayl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tentative
llvm::sys::sandbox::scopedDisables to intel/llvm code to re-enable IO sandbox: https://discourse.llvm.org/t/rfc-file-system-sandboxing-in-clang-llvm/88791Although upstream llvm components had
scopedDisable's added to necessary places, intel/llvm is still missing thesescopedDisables.