Draft
SYCL test: add compile-time conformance checks for group/sub_group comparison operators#22984
group/sub_group comparison operators#22984Conversation
Co-authored-by: mianowski <8652524+mianowski@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code as suggested in review comment
SYCL test: add compile-time conformance checks for Aug 20, 2026
group/sub_group comparison operators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the linked review feedback by adding compile-time coverage for SYCL 2020 comparison-operator requirements that were not validated in
group.cpp. The change is scoped to the single requested comment.What was missing
sycl/test/basic_tests/group.cpponly validated host runtime behavior forget_local_id/get_local_linear_id.group/sub_groupequality operators.What changed
static_asserts forsycl::group<1>andsycl::sub_groupto verify:operator==/operator!=(hidden-friend style),bool,noexcept.Example of added coverage