[SYCL] HostTask deadlock fix - #22993
Open
cperkinsintel wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple worker threads submitting to an in-order queue can deadlock when the application holds a mutex across q.submit() calls whose host_tasks acquire that same mutex.
The solution is to drain the synchronous host-task dep waits once, at the top of
GraphProcessor::waitForEvent, before callingenqueueCommand. A newcollectPendingHostDepEventswalks Cmd's dep graph under the read lock and gathers every host-task event that would otherwise be waited on synchronously. Then we release the read lock, wait for them all, reacquire, and proceed with the normalenqueueCommand. Its internalwaitForPreparedHostEventscalls now find events already signaled and return immediately, so the read lock is no longer held across any blocking host wait.