Skip to content

Fix HiDiffusion ratio overrides and SDXL T2 behavior - #9511

Open
DustyShoe wants to merge 19 commits into
invoke-ai:mainfrom
DustyShoe:fix/hidiffusion-ratio-behavior
Open

Fix HiDiffusion ratio overrides and SDXL T2 behavior#9511
DustyShoe wants to merge 19 commits into
invoke-ai:mainfrom
DustyShoe:fix/hidiffusion-ratio-behavior

Conversation

@DustyShoe

@DustyShoe DustyShoe commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

This is a follow-up to #8787 that fixes correctness and compatibility issues found in the existing HiDiffusion integration.

  • Restore the original staged SDXL RAU-Net schedule semantics and apply ratio thresholds against logical denoising steps instead of individual UNet forwards.
  • Reuse window-attention shifts within a scheduler step and prevent schedule drift in guidance paths that perform multiple UNet calls.
  • Fix feature-map compatibility for Regional Guidance, ControlNet, and T2I-Adapter while RAU-Net is active.
  • Keep Automatic Ratios separate from manual T1/T2 slider values, preserve both modes through metadata recall and persisted-state migration, and validate T2 <= T1.
  • Stop applying HiDiffusion to the separate SDXL refiner stage, which is not covered by the upstream implementation.
  • Correct the T1/T2 UI descriptions, feature documentation, and vendored-source attribution.

Related Issues / Discussions

Follow-up to #8787.

Upstream reference: https://github.com/megvii-research/HiDiffusion

QA Instructions

  1. Generate SDXL at 2048x2048 with 50 DDIM steps and Automatic Ratios; inspect the transitions around the early RAU-Net boundary and T1.
  2. Disable Automatic Ratios and confirm the previous manual T1/T2 values are preserved. Compare with manual T1=0.4, T2=0.16 using the same seed.
  3. Recall images generated in automatic and manual modes and confirm the correct mode and values are restored.
  4. Repeat representative txt2img cases with Euler A.
  5. Smoke-test img2img, inpainting, Regional Guidance, ControlNet, and T2I-Adapter.

Merge Plan

No special merge handling is required.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Changes to a redux slice have a corresponding migration
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions Bot added python PRs that change python files invocations PRs that change invocations backend PRs that change backend files frontend PRs that change frontend files python-tests PRs that change python tests docs PRs that change docs labels Aug 16, 2026
@lstein lstein added the 6.14.1 label Aug 17, 2026
@lstein lstein moved this to 6.14.x Theme: USER EXPERIENCE in Invoke - Community Roadmap Aug 17, 2026
@lstein lstein moved this from 6.14.x Theme: USER EXPERIENCE to 6.14.1: Bug fixes to 6.14.0 in Invoke - Community Roadmap Aug 17, 2026
@DustyShoe
DustyShoe marked this pull request as ready for review August 20, 2026 14:09
@DustyShoe
DustyShoe force-pushed the fix/hidiffusion-ratio-behavior branch from cc121ba to c9eb228 Compare August 24, 2026 08:32
@DustyShoe
DustyShoe marked this pull request as draft August 27, 2026 22:05
DustyShoe and others added 3 commits August 31, 2026 02:04
Restore staged logical-step scheduling and guidance residual compatibility. Preserve manual ratios behind Auto, validate T2 <= T1, and exclude the unsupported refiner path.
@github-actions github-actions Bot added the Root label Sep 6, 2026
@DustyShoe
DustyShoe marked this pull request as ready for review September 6, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.14.1 backend PRs that change backend files docs PRs that change docs frontend PRs that change frontend files invocations PRs that change invocations python PRs that change python files python-tests PRs that change python tests Root

Projects

Status: 6.14.1: Bug fixes to 6.14.0

Development

Successfully merging this pull request may close these issues.

3 participants