Skip to content

fix: replace raise e with bare raise and improve error propagation in getBatchDetailsIter #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Adichapati wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: replace raise e with bare raise and improve error propagation in getBatchDetailsIter #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ipinfo/handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ def getBatchDetails(
quota errors.
Defaults to on.
"""
if batch_size == None:
if batch_size is None:
batch_size = BATCH_MAX_SIZE

result = {}
Expand Down Expand Up @@ -391,14 +391,20 @@ def getBatchDetailsIter(

try:
response = requests.post(url, json=batch, headers=headers)
except Exception as e:
raise e
except Exception:
raise
Comment on lines 392 to +395

# evaluate HTTP status before parsing response body
status_code = response.status_code
try:
if response.status_code == 429:
if status_code == 429:
raise RequestQuotaExceededError()
response.raise_for_status()
except RequestQuotaExceededError:
raise
Comment on lines 399 to +404
except Exception as e:
if status_code == 429 and not isinstance(e, RequestQuotaExceededError):
raise RequestQuotaExceededError() from e
return handler_utils.return_or_fail(raise_on_fail, e)
Comment on lines +403 to 408

details = response.json()
Expand Down