Skip to content

Disable running controller with both ipxe and httpboot method #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hardikdr wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −1
Open

Disable running controller with both ipxe and httpboot method #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96a7786
Disable running controller with both ipxe and httpboot method
hardikdr Aug 24, 2026
ec527e2
Fix lint and code-gen error
hardikdr Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ linters:
- errcheck
- ginkgolinter
- goconst
- gocyclo
- govet
- ineffassign
- lll
Expand Down
9 changes: 9 additions & 0 deletions cmd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,15 @@ func main() {
setupLog.Info("Ignoring --default-httpboot-uki-url because --default-httpboot-oci-image is set")
}

ipxeControllersEnabled := controllers.Enabled(ipxeBootConfigController) || controllers.Enabled(serverBootConfigControllerPxe)
httpControllersEnabled := controllers.Enabled(httpBootConfigController) || controllers.Enabled(serverBootConfigControllerHttp)
if ipxeControllersEnabled && httpControllersEnabled {
setupLog.Error(nil, "invalid controller combination: iPXE and HTTPBoot controllers cannot run together; "+
"use --controllers to enable only one boot method group "+
"(ipxe group: ipxebootconfig, serverbootconfigpxe; http group: httpbootconfig, serverbootconfighttp)")
os.Exit(1)
}

// set the correct ipxe service URL by getting the address from the environment
if controllers.Enabled(ipxeBootConfigController) || controllers.Enabled(serverBootConfigControllerPxe) {
if ipxeServiceURL == "" {
Expand Down
Loading