Bugfix unstable database order - #137
Open
Louwrensth wants to merge 1 commit into
Open
Louwrensth wants to merge 1 commit into
Louwrensth wants to merge 1 commit into
Conversation
Louwrensth
requested review from
SimonPinches,
Yannicked,
maarten-ic,
olivhoenen and
prasad-sawantdesai
as code owners
September 29, 2026 15:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes unstable pagination in the database layer (
src/simdb/database/database.py) by making simulation listing order deterministic.Changes
DatabaseErrorwhen an unknown sort column is requested.Query.all()call.limit) when no stable sort is applied.Validation
24 passedintests/database/test_metadata_queries.py