Default MSVC static CRT for static yaml-cpp builds - #1484
Draft
harleywilsoneng wants to merge 6 commits into
Draft
Default MSVC static CRT for static yaml-cpp builds#1484harleywilsoneng wants to merge 6 commits into
harleywilsoneng wants to merge 6 commits into
Conversation
Signed-off-by: harleywilsoneng <harleywilsoneng@users.noreply.github.com>
Signed-off-by: harleywilsoneng <harleywilsoneng@users.noreply.github.com>
Signed-off-by: harleywilsoneng <harleywilsoneng@users.noreply.github.com>
Signed-off-by: harleywilsoneng <harleywilsoneng@users.noreply.github.com>
Signed-off-by: harleywilsoneng <harleywilsoneng@users.noreply.github.com>
Signed-off-by: harleywilsoneng <harleywilsoneng@users.noreply.github.com>
Collaborator
|
Amazing! This is highly appreciated! I took the liberty to convert it to a "draft" PR. Please convert it back to a normal PR when it is ready to be reviewed. |
SGSSGene
marked this pull request as draft
August 13, 2026 04:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1354
Summary
YAML_MSVC_SHARED_RTto${YAML_BUILD_SHARED_LIBS}so static yaml-cpp builds use/MTby default on MSVC.YAML_CPP_STATIC_DEFINEfor consumers linking the static library.Test plan
/MTis selected by default.-DYAML_MSVC_SHARED_RT=ONand verify/MDis still available.