feat(complete): complete sigil-prefixed positionals - #1319
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5110a33 to
bcfbb7d
Compare
bcfbb7d to
25838cc
Compare
25838cc to
e469a24
Compare
5609fce to
9b1f823
Compare
683bbed to
ace249e
Compare
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes. Shadow comparisonParsing
|
6f6f260 to
5c3c3a1
Compare
5c3c3a1 to
c92343c
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c92343c. Configure here.

Summary
Stack
Test plan
AI-assisted — Tool: Codex; model: OpenAI/GPT-5; version: unavailable.
Note
Low Risk
Changes are confined to completion paths with new tests; parsing behavior is assumed from the dependent stack (#1322), not modified here.
Overview
Adds shell completion for sigil arguments (
arg sigil="+"and similar): tokens like+nare treated as the declared positional after stripping the prefix, then candidates are emitted with the sigil restored (+node@22, etc.).Both usage-argv (
complete.rs) and the CLI reference (complete_word) share the same rules: longest matching sigil wins, flag values and explicit--/ restart boundaries /double_dash="automatic"stop sigil classification, and cwd file fallback is suppressed while completing a sigil-shaped word (including dynamicrun=completers that see the strippedwords[CURRENT]).Documentation adds a sigils reference page, a sigil.usage.kdl example, and tests cover choices, separators, restart tokens, overlays, and runtime completers.
Reviewed by Cursor Bugbot for commit 895f5f3. Bugbot is set up for automated code reviews on this repo. Configure here.