fix: bare L day-of-week means every Saturday (#716) - #721
Open
arimu1 wants to merge 1 commit into
Open
Conversation
Map bare L from Quartz numbering (7/SAT) instead of the definition's scheme so SPRING53 and similar 0-7 Monday=1 ranges schedule Saturday. Describe bare L as every Saturday; keep nL as last weekday of month.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #716
Bare
Lin the day-of-week field (as opposed tonL) has two defects:last Sunday of every month(wrong day and wrong “last of month” semantics). BareLmeans every Saturday ("7"/"SAT").OnDayOfWeekValueGeneratorheld Saturday as Quartz7, then mapped that value with the definition’s day-of-week scheme, so SPRING53 (mondayDoWValue = 1,7→0) scheduled every Sunday instead of every Saturday.Changes
OnDayOfWeekValueGenerator: for bareL, mapON_SATURDAY(value7) fromConstantsMapper.QUARTZ_WEEK_DAY→ JAVA8, not from the definition’smondayDoWValue.nL/NONEpaths unchanged.DescriptionStrategyFactory(used byCronDescriptor): bareLdescribes asevery Saturday;nLstill describes aslast <weekday> of every month.Tests
Issue716Test: Quartz + SPRING53 description and next five executions from 2025-06-01 (all Saturday, matching issue table);nLregression.Temurin 21 — green.