Adding Overloads to Logger.logDatabaseErrors() methods with List<SObjects> - #985
Merged
jongpie merged 8 commits intoAug 4, 2026
Conversation
Owner
|
Thanks for making this PR @DivyanshuBist! I am planning to review & merge this in the next few days. |
jongpie
added
Logging Source: Apex
github-actions Bot
pushed a commit
to nebulity/NebulaLogger
that referenced
this pull request
Jun 14, 2026
jongpie
modified the milestones:
Version 4.19.0: Spring '26 Release,
Version 4.20.0: Summer '26 Release
…mplementation to preserve the SObjectType of the list parameter, suppressed PMD violations for ExcessiveParameterList on the new overloads, tweaked ApexDocs comments, generated updated Apex docs files, and ran prettier to format new overloads
…ignore the List<SObject> records when the size doesn't match the list of database results Previously, the implementation was returning an error entry indicating that the sizes doesn't match - that causes data loss because the original message, logging level, and database results weren't being logged at all
…loads and LogEntryEventBuilder.setDatabaseResult() overloads to treat a list with 1 record as a list, instead of as a single instance This makes it consistent with the behavior of setRecord() overloads
jongpie
approved these changes
Aug 4, 2026
jongpie
left a comment
jongpie
left a comment
Owner
There was a problem hiding this comment.
Hi @DivyanshuBist - thanks for working on this PR! I spent the last day or two reviewing & have pushed several changes to the PR, including:
- Adding tests
- Changing the behavior when the list of database results & the list of SObject recoreds don't match. Now it just simply ignores the list of SObject records when there's a mismatch.
- Scope creep: there was some existing behavior in
LogEntryEventBuilderthat I didn't like, so I've tweaked the behavior in this PR
I'm planning to merge & release this later today 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for #942 ,
added overloads for Logger.logDatabaseErrors with parameter List