Update composer.json authors to reflect current active maintainer - #928
Open
DannyvdSluijs wants to merge 1 commit into
Open
Update composer.json authors to reflect current active maintainer#928DannyvdSluijs wants to merge 1 commit into
DannyvdSluijs wants to merge 1 commit into
Conversation
The original founding authors have not been active contributors in years; listing them as authors implies responsibility for present-day issues (e.g. security reports) they have no involvement in. Lists the current active maintainer instead so people can reach out directly. Refs #927
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authorsarray incomposer.json, which still listed the four original founders (inactive for years), with the current active maintainer.Why
See #927 for full rationale. Short version: keeping inactive founders listed as authors implies they're responsible for present-day issues (e.g. CVEs) they have no involvement in, and doesn't let people reach out to whoever is actually maintaining the project today.
Closes #927
Test plan
php -r "json_decode(file_get_contents('composer.json')); echo json_last_error_msg();"→No errorcomposer validate→ composer.json itself reports valid (unrelated pre-existing lock file drift noted, not touched by this change)