Add SubnetPool controller#844
Open
winiciusallan wants to merge 4 commits into
Open
Conversation
dlaw4608
reviewed
Jul 9, 2026
dlaw4608
reviewed
Jul 9, 2026
dlaw4608
left a comment
dlaw4608
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR @winiciusallan ran through the e2e tests all work locally, overall the controller looks really good, only have the minor question regarding the mutability of the shared field
$ go run ./cmd/scaffold-controller -interactive=false \
-gophercloud-client=NewNetworkV2 \
-kind SubnetPool \
-gophercloud-module=github.com/gophercloud/gophercloud/v2/openstack/networking/v2/extensions/subnetpools \
-import-dependency Project \
-import-dependency AddressScope \
-optional-create-dependency Project \
-optional-create-dependency AddressScope
winiciusallan
force-pushed
the
subnet-pool-controller
branch
from
97fd880 to
64d0da4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the SubnetPool controller, which delegates the manage of subnet addresses allocation to Neutron.
Notes:
DefaultQuota, because we can't unset it, neither create it as0.<Min|Max>PrefixLengthrequired in the API, because we can't unset them when updating. Another possibility is to keep them immutable.Closes #393