DRAFT (Not tested) Dynamic added miners - #38
Open
CryptoPascal31 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on Amir's work and proposal.
Currently, allowed miners are defined statically within the config file (Mining coordination).
This is good for solo miners, but not ideal when you want to make a shared mining pool ...
The idea of this PR is to allow miners to be added dynamically when they request work.
But there are resources concerns: a register miner takes some resources (block building for every block + 2 threads).
To mitigate that:
Anyway, it's fine if we don't merge this immediately, it can live on its own branch for now.