Migrate to Nucleus 2.0 and drop platformtools/SingleInstanceManager#410
Merged
Conversation
- Bump Nucleus to 2.0.0-alpha, migrate coordinates/plugin id/packages to dev.nucleusframework - Replace platformtools with Nucleus core-runtime Platform and LinuxDesktopEnvironment - Remove bundled SingleInstanceManager in favor of the one provided by Nucleus core-runtime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.12.0→2.0.0-alpha-202607101252: groupio.github.kdroidfilter→dev.nucleusframework(artifact names unchanged), Gradle plugin idio.github.kdroidfilter.nucleus→dev.nucleusframework.io.github.kdroidfilter.nucleus.{darkmodedetector,graalvm,desktop.application.dsl}→dev.nucleusframework.*.platformtools.coredependency, replacing its OS/desktop detection with Nucleuscore-runtime:getOperatingSystem()/OperatingSystem.*→Platform.Current/Platform.{Windows,MacOS,Linux,Unknown}, anddetectLinuxDesktopEnvironment()→LinuxDesktopEnvironment.Current(now non-null,Unknowninstead ofnull).utils/SingleInstanceManager.kt; demos now usedev.nucleusframework.core.runtime.SingleInstanceManager(identical API). README updated.Notes
TrayAppDemokeepsapplication { }:TrayApp/Trayrequire Compose'sApplicationScope(forDialogWindow), whichnucleusApplicationdoes not expose publicly.Test plan
./gradlew :compileKotlinJvm :demo:compileKotlinJvm