Add browser proxy routes to CLI create - #269
Merged
Merged
Conversation
hiroTamada
marked this pull request as ready for review
September 24, 2026 19:49
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
chruffins
approved these changes
Sep 24, 2026
chruffins
left a comment
Contributor
There was a problem hiding this comment.
reviewed — looks good, limits match the API validator (10 routes, 1–50 hosts, exactly one of id/name). a few things worth a look:
Questions
go.mod:12— the v0.112.0 bump also changes the webmcp list response format (tools[].name→tools[].tool.name,read_only→readOnlyHint). is that API change already deployed to prod? if the CLI ships first,browsers webmcp listshows empty tool names and read-only flagscmd/browsers.go:3248/README.md:258— the API spec says setting routes requires proxy v3. might be worth mentioning so users aren't surprised by the API error
Nits
cmd/browsers_webmcp.go:42-60—browsers webmcp list -o jsonoutput changes format with the SDK bump, which breaks scripts reading the old fields. consider a line in the release notescmd/browsers.go:3248— nit: flag help saysstart_url; the README says--start-urlcmd/browsers.go:251— nit: rejecting any=in the selector means a proxy with=in its name can't be selected withname:. probably fine, just flagging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--proxy-routewith typed SDK request construction and light syntax/count validation.Validation
go test ./...andmake testpassed.make buildpassed;gofmtandgit diff --checkclean.make lintran with 70 existing repo-wide findings (50 errcheck, 3 ineffassign, 16 staticcheck, 1 unused); none on changed lines.Note
Medium Risk
Changes browser session egress configuration at creation time and upgrades the SDK; incorrect routes could misroute traffic, though host matching is API-validated and routes are create-only.
Overview
Adds create-only
--proxy-routetokernel browsers create, mappingHOST[,HOST...]=PROXY(proxy ID by default, orid:/name:) into the browser network config with client-side limits (10 routes, 50 hosts per route) and rejection when combined with pool acquire flags.Network request shaping now omits empty
private_hostsand only sendsnetworkwhen private hosts or proxy routes are present; create/get table output adds a Proxy Routes row alongside private hosts.Bumps kernel-go-sdk to v0.112.0 and updates WebMCP list for the new tool payload shape (
tool.name,readOnlyHint) andListToolsparams. README documents the new flag.Reviewed by Cursor Bugbot for commit 72f0623. Bugbot is set up for automated code reviews on this repo. Configure here.