Skip to content

Add browser proxy routes to CLI create - #269

Merged
hiroTamada merged 3 commits into
mainfrom
hypeship/browser-proxy-routes
Sep 24, 2026
Merged

hiroTamada merged 3 commits into
mainfrom
hypeship/browser-proxy-routes

Conversation

@hiroTamada

@hiroTamada hiroTamada commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add repeatable, create-only --proxy-route with typed SDK request construction and light syntax/count validation.
  • Display returned proxy routes alongside private hosts in create/get output, including SDK-backed JSON output.
  • Upgrade kernel-go-sdk to v0.112.0 and adapt WebMCP list handling to its updated SDK types.

Validation

  • go test ./... and make test passed.
  • make build passed; gofmt and git diff --check clean.
  • make lint ran with 70 existing repo-wide findings (50 errcheck, 3 ineffassign, 16 staticcheck, 1 unused); none on changed lines.
  • No live API smoke test performed.

Note

Medium Risk
Changes browser session egress configuration at creation time and upgrades the SDK; incorrect routes could misroute traffic, though host matching is API-validated and routes are create-only.

Overview
Adds create-only --proxy-route to kernel browsers create, mapping HOST[,HOST...]=PROXY (proxy ID by default, or id: / name:) into the browser network config with client-side limits (10 routes, 50 hosts per route) and rejection when combined with pool acquire flags.

Network request shaping now omits empty private_hosts and only sends network when private hosts or proxy routes are present; create/get table output adds a Proxy Routes row alongside private hosts.

Bumps kernel-go-sdk to v0.112.0 and updates WebMCP list for the new tool payload shape (tool.name, readOnlyHint) and ListTools params. README documents the new flag.

Reviewed by Cursor Bugbot for commit 72f0623. Bugbot is set up for automated code reviews on this repo. Configure here.

@hiroTamada
hiroTamada marked this pull request as ready for review September 24, 2026 19:49
@socket-security

socket-security Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgolang/​github.com/​kernel/​kernel-go-sdk@​v0.110.0 ⏵ v0.112.073 +1100100100100

View full report

@chruffins chruffins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed — looks good, limits match the API validator (10 routes, 1–50 hosts, exactly one of id/name). a few things worth a look:

Questions

  • go.mod:12 — the v0.112.0 bump also changes the webmcp list response format (tools[].name → tools[].tool.name, read_only → readOnlyHint). is that API change already deployed to prod? if the CLI ships first, browsers webmcp list shows empty tool names and read-only flags
  • cmd/browsers.go:3248 / README.md:258 — the API spec says setting routes requires proxy v3. might be worth mentioning so users aren't surprised by the API error

Nits

  • cmd/browsers_webmcp.go:42-60 — browsers webmcp list -o json output changes format with the SDK bump, which breaks scripts reading the old fields. consider a line in the release notes
  • cmd/browsers.go:3248 — nit: flag help says start_url; the README says --start-url
  • cmd/browsers.go:251 — nit: rejecting any = in the selector means a proxy with = in its name can't be selected with name:. probably fine, just flagging

@hiroTamada
hiroTamada merged commit f22b917 into main Sep 24, 2026
8 checks passed
@hiroTamada
hiroTamada deleted the hypeship/browser-proxy-routes branch September 24, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants