Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3bc99e5. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Depends on kernel/kernel#4256; do not merge before it lands and a Go SDK release includes it.
Summary
vaultsandvaults credentialshelp now describe two credential paths, Kernel-hosted collection and 1Password brokered approval, and tell agents to ask the user which one they want. They also say never to ask for passwords, OAuth codes, or keys in the terminal or chat.vaults credentials connect <vault> <account-key> --provider 1passwordcreates acredential_accountitem and shows the 1Password authorization URL. It always uses the Kernel-managed OAuth client.vaults credentials createsends the spec'sprovider. A spec without one defaults tokernel, so existing spec files keep working now that the API requires the field. A1passwordspec carriesaccount_idand a v2requestsobject.vaults items invokesupports1pw_create_access_request,1pw_access_request_status,1pw_fill, and1pw_recover, each only when the item advertises it. There is no reset or reconcile operation: after a failed or uncertain access request or fill, the help says to stop and tell the user rather than retry.1pw_recoverreturns a new link for recovering a failed account connection.typeitself.1pw_fill,fill_submittedexits 0.fill_failedandfill_unknownexit nonzero, and the guidance says not to retry.account_id,requests, the non-secretaccess_requestfields, and actioninstructions. The provider-opaqueidentityandpathare dropped. The nativeonepassword://grant-brokered-access?access_request_reference=…link is shown only on a1password_access_approvalaction with exactly that shape. Requestwebsitevalues go through the same URL filter as other URLs.Not included (design still under review)
customer_managedcredential accounts or1passwordvault-provider-configs). Only the Kernel-managed client is sent.credentials updatestill covers Kernel-hosted credentials only.Temporary SDK pin
go.modpins the Go SDK to the private stlc preview generated from kernel/kernel#4256 at edb30b1 (stlc run 36183731121):That is commit
a98c8419227eef638434cc6f9abb0fb63ba1d7c1onstlc/preview/pr-4256. The preview repository is private, so CI jobs that download modules without access to it (test, preview binaries) are expected to fail until the pin is swapped. Local builds needGOPRIVATE=github.com/kernel/*and access to that repository.TODO before merge: delete the
replaceline, bumpgithub.com/kernel/kernel-go-sdkto the official release that includes kernel/kernel#4256, and rungo mod tidy. The TODO is also ingo.mod.Validation
go build ./...,go vet ./..., andgo test ./...against the preview SDK: all pass.cmd/vaults_onepassword_test.gocovers:provider: "kernel"in create requests.golangci-lint, and any call against a live API. The API's 1Password broker is local-only in #4256.