Invoke advertised vault operations with generic inputs - #215
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6ae1383. Configure here.
hiroTamada
left a comment
There was a problem hiding this comment.
looks good overall. two non-blocking questions:
src/lib/mcp/tools/vault-items.ts:173-185— can the API ever returnstatus: "completed"with a missing or failed field outcome? the old fill response check treated that as unconfirmed; if it is possible, should we preserve that consistency check without tying it to an operation name?src/lib/mcp/vault-responses.ts:437-456— when passing through an API-marked provider rejection reason, should we also include the usual inspect-state/no-automatic-retry guidance? the specific error currently returns only the reason.
|
Thanks — the current API fill executor allocates one outcome per requested selector, and |

Summary
inputsand pass them directly toclient.vaults.items.performOperation; no MCP branch or schema names an operation. The API validates required inputs.inner_error, followed by inspect-state/no-automatic-retry guidance; otherwise use generic curated errors and conservative unknown-outcome guidance. Unmarked 429 rate limits stay distinct.Compatibility
fillargument now pass the same object asinputs. This intentionally changes the MCP tool schema while keeping the API request body unchanged.state.status_reason, and rejection item events.Tests
bun test(700 pass)bunx tsc --noEmit(pass)bun run format:checkflags pre-existingAGENTS.mdformatting.