Keep LAVA infrastructure failures incomplete#3120
Merged
Merged
Conversation
nuclearcat
force-pushed
the
kcidb-infra-error-status
branch
from
5acacc9 to
61d3ee0
Compare
Do not convert baseline jobs with Infrastructure error metadata from incomplete to fail when setup/login/kernel-message stages fail early. This preserves the callback status so downstream KCIDB reporting can publish ERROR instead of FAIL. Add regressions for early LAVA infrastructure failures with no setup results, login failures, and kernel-message failures. This is a best-effort fix for the old discussion around issue kernelci#1087. I am not fully sure this is the correct final fix because that discussion happened a while ago and I do not remember all the details, so this should get maintainer review against the original failure modes. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
nuclearcat
force-pushed
the
kcidb-infra-error-status
branch
from
61d3ee0 to
5aca08d
Compare
get_configs() matched a scheduler entry whenever the current event values satisfied it (level-triggered). Because a node event is emitted on every update, any update that left the node in an already-matching state (an artifact, timeout or flag change on an "available" node) re-triggered creation of the whole set of child jobs. A 6-month audit of production confirmed this happens routinely: across 26 sampled days (236,139 job nodes) there were 4,380 duplicate job groups -- identical parent/name/runtime/platform with the same retry_counter, created seconds apart -- with the rate rising sharply from late April 2026, reaching ~10% of jobs on some days. Make scheduling edge-triggered: fire only on the transition into the matched condition, using previous_state/previous_result now carried in the event. Falls back to the previous level-triggered behaviour when that information is absent (node creation, retry events, older API), so retries and freshly created nodes are unaffected. Fixes kernelci#2912 Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
nuclearcat
force-pushed
the
kcidb-infra-error-status
branch
from
5aca08d to
ad77864
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not convert baseline jobs with Infrastructure error metadata from incomplete to fail when setup/login/kernel-message stages fail early. This preserves the callback status so downstream KCIDB reporting can publish ERROR instead of FAIL.
Add regressions for early LAVA infrastructure failures with no setup results, login failures, and kernel-message failures.
This is a best-effort fix for the old discussion around issue #1087. I am not fully sure this is the correct final fix because that discussion happened a while ago and I do not remember all the details, so this should get maintainer review against the original failure modes.