auto: B19S1 merge master into staging - #838
Merged
Merged
Conversation
Test-bot: skip
auto: refresh contributors
Test-bot: skip
fix: validate bcp47 parameter properly
As the PHP 7.4 image broke with missing security dependencies in Debian Bullseye (at time of writing, as yet unresolved), resolved to complete the upgrade to PHP 8.4 rather than try to build a stopgap solution based on existing PHP 7.4. Unfortunately PHP 8.4 has a number of incompatible changes in 8.x series, documented at https://www.php.net/manual/en/migration80.incompatible.php. I have audited some of the more obvious ones -- but there is potential for other breakages which we will need to monitor. Changes required: * move from PHP 7.4 to PHP 8.4 Docker image (upgrades Debian, Apache, PHP as major components) * dependency upgrades forced for Sentry, phpunit, curl-client * addition of BCTLS flag to .htaccess mod_rewrite rules (https://stackoverflow.com/q/75684314/1836776) * Fixup of several unencoded URLs Other changes to come include handling excessive warnings in logs: * sentry/sentry: [warning] The "zend.exception_ignore_args" PHP setting is enabled which results in missing stack trace arguments, see: https://docs.sentry.io/platforms/php/troubleshooting/#missing-variables-in-stack-traces. * sentry/sentry: [debug] The "Sentry\Integration\ExceptionListenerIntegration, Sentry\Integration\ErrorListenerIntegration, Sentry\Integration\FatalErrorListenerIntegration, Sentry\Integration\RequestIntegration, Sentry\Integration\TransactionIntegration, Sentry\Integration\FrameContextifierIntegration, Sentry\Integration\EnvironmentIntegration, Sentry\Integration\ModulesIntegration" integration(s) have been installed. Relates-to: keymanapp/keymanweb.com#209 Test-bot: skip
maint: move to PHP 8.4, Apache 2.4.68
* Address more deprecations * Upgrade parsedown, parsedown-extra to 8.4-compatible version * Support prod vs dev php.ini properly * Include BUILDER_PLATFORM env variable for tests * Add '--no-cache' parameter for building Docker image Test-bot: skip Fixes: #830 Fixes: #831 Fixes: KEYMAN-COM-4H4 Fixes: KEYMAN-COM-4H5
Test-bot: skip
auto: refresh contributors
chore: additional cleanup after PHP 8.4 upgrade
…v1.0.21 auto: update shared-sites version to v1.0.21
keyman-status
approved these changes
Sep 15, 2026
keyman-status
enabled auto-merge
September 15, 2026 12:39
github-actions
Bot
added
the
auto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-bot: skip