refactor(web): update function comments and cleanup - #16591
Draft
ermshiperete wants to merge 1 commit into
Draft
ermshiperete wants to merge 1 commit into
ermshiperete wants to merge 1 commit into
Conversation
User Test ResultsTest specification and instructions User tests are not required |
ermshiperete
added this pull request to stack #16593
September 17, 2026 15:12
ermshiperete
removed this pull request from stack #16593
September 17, 2026 15:59
ermshiperete
added this pull request to stack #16594
September 17, 2026 16:04
ermshiperete
force-pushed
the
refactor/web/cleanup
branch
from
September 17, 2026 16:05
2f3c1eb to
94746cb
Compare
ermshiperete
removed this pull request from stack #16594
September 17, 2026 16:07
ermshiperete
added this pull request to stack #16595
September 17, 2026 16:08
ermshiperete
force-pushed
the
refactor/web/cleanup
branch
from
September 17, 2026 16:39
94746cb to
3701093
Compare
ermshiperete
removed this pull request from stack #16595
September 17, 2026 16:40
ermshiperete
added this pull request to stack #16596
September 17, 2026 16:49
ermshiperete
removed this pull request from stack #16596
September 17, 2026 16:54
- modernize function comments - modernize function signatures - rename variables and arguments Build-bot: skip build:web Test-bot: skip
ermshiperete
added this pull request to stack #16598
September 17, 2026 17:10
ermshiperete
force-pushed
the
refactor/web/cleanup
branch
from
September 17, 2026 17:14
3701093 to
ba7fa02
Compare
ermshiperete
marked this pull request as draft
September 17, 2026 18:37
mcdurdin
approved these changes
Sep 18, 2026
mcdurdin
left a comment
mcdurdin
left a comment
Member
There was a problem hiding this comment.
OK, but probably this kind of cleanup should wait for A20S1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build-bot: skip build:web
Test-bot: skip
Stack created with GitHub Stacks CLI • Give Feedback 💬